feat: Pub/Sub auto-decompression #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
added
C-feature
Merged
feat: snappy compression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CompressionTypebyte in pub/sub message headers, which enables the sub socket to decompress each message individually. More compression types can be added in the future by just extending this enum.PubOption:min_compress_sizeto set a payload size threshold under which to skip compression.In practice, it is no longer necessary to specify a
Decompressorwhen creating aSubSocket. This also solves the issue in #41 where the sub socket might have expected a specific compression type from different publishers.Benchmarks
Results are not clear yet, the existing pubsub bench didn't show any big difference, which is expected.
Probably a before / after profiler run will be useful here (yet todo).
SubSocket: specify decompressor on a connection level #41